Directive definition in a variable #36
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds implicit annotation support for directive definitions
that are returned from a variable.
Currently, implicit annotations only work for a directive if the
directive definition is returned as an object literal.
We have used the former quite a lot in our codebase, so we
needed to add support for it. I understand that the general
recommendation for more complex use cases like this is to add
explicit annotations, but here's a PR for the feature anyway
if you are interested. All the tests pass and I added one more
to test this specific case.