Use overload instead of override to implement Assertions.{assert, assume} #1824
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Because dotty don't permit
inline def
overrideinline def
, so in commit 3cfd618, inAssertions.{assert, assume}
, we pass'this
toAssertionsMacro
. And inAssertionsMacro
, we switch the implementation logic of assert/ assume based on type of the passed param.Problem
The solution above is not flexible enough if we want to extends Assertions as in scalatest/scalatestplus-junit project.
Solution in this PR
As suggested in Remove uses of inline overriding inline scala/scala3#8601 (review), I use overload instead of override to implement
Assertions.{assert, assume}