Skip to content

Use overload instead of override to implement Assertions.{assert, assume} #1824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

ohze
Copy link

@ohze ohze commented Jun 10, 2020

@ohze
Copy link
Author

ohze commented Jun 10, 2020

Note: This PR must be merged before scalatestplus-junit can support dotty by scalatest/scalatestplus-junit#12

@cheeseng
Copy link
Contributor

@ohze @bvenners Since 3.2.0 is around the corner, may I suggest we bring this dotty support to 3.2.0 instead of 3.1.x?

@cheeseng
Copy link
Contributor

@ohze Fyi I have cherry-pick your commit(s) into this branch here for the upcoming 3.2.0:

https://github.com/scalatest/scalatest/tree/feature-3.2.0-with-dotty-improvements

@cheeseng
Copy link
Contributor

@ohze Fyi changes included in this new PR for 3.2.0 #1827

@cheeseng
Copy link
Contributor

@ohze Closing as this is now merged into 3.2.x-new and included in 3.2.0 release.

@cheeseng cheeseng closed this Jul 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants