Skip to content

Add 2024 day 19 article #819

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jan 2, 2025
Merged

Conversation

AvaPL
Copy link
Contributor

@AvaPL AvaPL commented Dec 28, 2024

I'm quite surprised that this one doesn't have an article yet, so I decided to write it 😄

Happy New Year!

Related PR with the code: #818.

@AvaPL AvaPL mentioned this pull request Dec 28, 2024
@AvaPL AvaPL changed the title Add day 19 article Add 2024 day 19 article Dec 28, 2024
Copy link

@twentylemon twentylemon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Happy new year to you as well!

@merlinorg
Copy link
Contributor

Need to update Solver.scala and, when the code PR merges, solutions.

@AvaPL
Copy link
Contributor Author

AvaPL commented Dec 29, 2024

You're right, I omitted Solver.scala in my initial commit. Should be good now.

Regarding the solutions, I wasn't sure whether I should include the the submodule stuff in the PR. That's not my first time submitting an article, but the first time submitting one with code 😅 Thanks for pointing that out! I'll include it once the code PR is approved and merged.

@adpi2
Copy link
Member

adpi2 commented Dec 30, 2024

The code has been merged, so you can now include the submodule.

@AvaPL
Copy link
Contributor Author

AvaPL commented Dec 31, 2024

Thank you! I rebased and updated the submodules. After building the page locally with yarn, it works fine 😄

Copy link
Contributor

@scarf005 scarf005 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SethTisue SethTisue merged commit b576834 into scalacenter:website Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants