Add support for ignored dependencies #51
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adpi2
reviewed
Aug 9, 2022
| @@ -106,6 +106,7 @@ object GithubDependencyGraphPlugin extends AutoPlugin { | |||
| val scalaBinaryVersion = (Keys.artifactName / Keys.scalaBinaryVersion).value | |||
| val crossVersion = CrossVersion.apply(scalaVersion, scalaBinaryVersion) | |||
| val allDirectDependencies = Keys.allDependencies.value | |||
| val ignoredDependencies = Keys.state.value.attributes(githubSubmitInputKey).ignoredDependencies | |||
There was a problem hiding this comment.
The githubSubmitInputKey attribute is set by the githubSubmitDependencyGraph command here.
I suggest to add a default value, for the task not to fail if the attribute is missing:
Suggested change
| val ignoredDependencies = Keys.state.value.attributes(githubSubmitInputKey).ignoredDependencies | |
| val ignoredDependencies = Keys.state.value.attributes.get(githubSubmitInputKey).toSeq.flatMap(_.ignoredDependencies) |
adpi2
reviewed
Aug 9, 2022
| @@ -137,7 +145,7 @@ object GithubDependencyGraphPlugin extends AutoPlugin { | |||
| configReport <- report.configurations | |||
| moduleReport <- configReport.modules | |||
| moduleRef = getReference(moduleReport.module) | |||
| if !moduleReport.evicted && !alreadySeen.contains(moduleRef) | |||
| if !moduleReport.evicted && !alreadySeen.contains(moduleRef) && !isIgnored(moduleReport.module) | |||
There was a problem hiding this comment.
This will filter out the library but not its transitive dependencies. Maybe I am wrong but I think it would be quite hard to filter out all transitive dependencies of a library. To do so we would need to build the entire tree of parents and check that all roots are ignored. Unfortunately, in a module report we only have one level of parents: moduleReport.callers.
What about filtering out entire configs rather than dependencies? That would be easier to implement.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A WIP for tackling #49 by allowing users to filter certain dependencies like scala3doc. Doesn't work yet as passing of the argument isn't implemented in a sot-compatible way.