Skip to content

Fix opening paren matches with closing paren in character literal #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 30, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/typescript/Scala.tmLanguage.ts
Original file line number Diff line number Diff line change
Expand Up @@ -583,7 +583,7 @@ export const scalaTmLanguage: TmLanguage = {
name: 'punctuation.definition.character.end.scala'
}
},
name: 'constant.character.literal.scala'
name: 'string.quoted.other constant.character.literal.scala'
},
initialization: {
match: '\\b(new)\\s+([^\\s,\\{\\}\\(\\)\\[\\]]+)',
Expand Down
2 changes: 1 addition & 1 deletion syntaxes/Scala.tmLanguage.json

Large diffs are not rendered by default.

24 changes: 12 additions & 12 deletions tests/snap/lexical.test.scala.snap
Original file line number Diff line number Diff line change
Expand Up @@ -193,21 +193,21 @@
> ('a', '\u0041', '\n', '\t')
#^^^^ source.scala
# ^ source.scala meta.bracket.scala
# ^ source.scala constant.character.literal.scala punctuation.definition.character.begin.scala
# ^ source.scala constant.character.literal.scala
# ^ source.scala constant.character.literal.scala punctuation.definition.character.end.scala
# ^ source.scala string.quoted.other constant.character.literal.scala punctuation.definition.character.begin.scala
# ^ source.scala string.quoted.other constant.character.literal.scala
# ^ source.scala string.quoted.other constant.character.literal.scala punctuation.definition.character.end.scala
# ^^^^^ source.scala
# ^ source.scala constant.character.literal.scala punctuation.definition.character.begin.scala
# ^^^^^^ source.scala constant.character.literal.scala constant.character.escape.scala
# ^ source.scala constant.character.literal.scala punctuation.definition.character.end.scala
# ^ source.scala string.quoted.other constant.character.literal.scala punctuation.definition.character.begin.scala
# ^^^^^^ source.scala string.quoted.other constant.character.literal.scala constant.character.escape.scala
# ^ source.scala string.quoted.other constant.character.literal.scala punctuation.definition.character.end.scala
# ^^^^^ source.scala
# ^ source.scala constant.character.literal.scala punctuation.definition.character.begin.scala
# ^^ source.scala constant.character.literal.scala constant.character.escape.scala
# ^ source.scala constant.character.literal.scala punctuation.definition.character.end.scala
# ^ source.scala string.quoted.other constant.character.literal.scala punctuation.definition.character.begin.scala
# ^^ source.scala string.quoted.other constant.character.literal.scala constant.character.escape.scala
# ^ source.scala string.quoted.other constant.character.literal.scala punctuation.definition.character.end.scala
# ^^^^^ source.scala
# ^ source.scala constant.character.literal.scala punctuation.definition.character.begin.scala
# ^^ source.scala constant.character.literal.scala constant.character.escape.scala
# ^ source.scala constant.character.literal.scala punctuation.definition.character.end.scala
# ^ source.scala string.quoted.other constant.character.literal.scala punctuation.definition.character.begin.scala
# ^^ source.scala string.quoted.other constant.character.literal.scala constant.character.escape.scala
# ^ source.scala string.quoted.other constant.character.literal.scala punctuation.definition.character.end.scala
# ^ source.scala meta.bracket.scala
>}
#^ source.scala punctuation.section.block.end.scala
Expand Down
6 changes: 6 additions & 0 deletions tests/unit/lexical.test.scala
Original file line number Diff line number Diff line change
Expand Up @@ -170,3 +170,9 @@ object Xml {
<authors>{scalaBook.authors.mkList("", ", ", "")}</authors>
</book>
}

class Parens {
capture("layout(" ~ oneOrMore(CharPredicate.All -- ")" -- ')') ~ ")")
// ^ string.quoted.other constant.character.literal.scala
capture("layout(" ~ oneOrMore(CharPredicate.All -- ")" -- `)`) ~ ")")
}