Skip to content

Add top level rule for identifiers inside the backticks #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 25, 2019

Conversation

PanAeon
Copy link
Contributor

@PanAeon PanAeon commented Jun 25, 2019

fixes #30

The only thing is that this fix changes how capital letter identifiers are highlighted inside of the back-quotes:

backticks

So previously `MediaRange` would be marked as "entity.name.class", but now it's just a plain id. I don't think it is terribly important though, as most people wouldn't use back-quotes as a class name but maybe to define some constants.

Copy link
Contributor

@olafurpg olafurpg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Thank you! You should have merge rights in the repo now, feel free to publish a new release if you want 😄

object `Backtics test` {
val x = MediaRange.`*/*`

val y = `MediaRange`.`*/*`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking forward to enjoy this fix on GitHub.com 😄

Screenshot 2019-06-25 at 13 26 48

@PanAeon PanAeon merged commit be0c909 into scala:master Jun 25, 2019
@PanAeon PanAeon deleted the feature/backticks branch June 25, 2019 12:55
@PanAeon
Copy link
Contributor Author

PanAeon commented Jun 25, 2019

Thank you) I'll try to publish a new release...

@olafurpg
Copy link
Contributor

Looks like the release went through 🎉

Screenshot 2019-06-25 at 15 48 15

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fields with */ confused for comments
2 participants