Welcome PanAeon to the team! #37
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PanAeon has made so many valuable contributions to the VS Code Scala Syntax highlighting rules: - translate the old XML file into TypeScript - fix highlighting for string interpolators, nested comments, non-ascii identifiers, symbol literals, ..., the list goes on. Thank you so much for your work!
olafurpg
commented
Jun 25, 2019
|
|
||
| - Olafur Pall Geirsson - [`@olafurpg`](https://github.com/olafurpg) | ||
| - Nicolas Stucki- [`@nicolasstucki`](https://github.com/nicolasstucki) | ||
| - Vitalii Voloshyn - [`@PanAeon`](https://github.com/PanAeon) |
There was a problem hiding this comment.
@PanAeon I inferred this name from your gmail address, please correct me if I got it wrong 😅
|
Thank you! 😃 I'm really glad to be useful) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PanAeon has made so many valuable contributions to the VS Code Scala
Syntax highlighting rules:
identifiers, symbol literals, ..., the list goes on.
Thank you so much for your work!
@PanAeon you should have received a collaborator invite via https://github.com/scala/vscode-scala-syntax/invitations. Feel free to merge this PR once you have accepted the invite.