Capture using followed by quote splice
#181
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaximeKjaer
previously approved these changes
Jan 16, 2021
src/typescript/Scala.tmLanguage.ts
Outdated
| @@ -425,7 +425,7 @@ export const scalaTmLanguage: TmLanguage = { | |||
| 'using': { | |||
| patterns: [ | |||
| { | |||
| match: `(?<=\\()\\s*(using)\\s+(?=[\\w\\d\\(\\.\\(\\{'"])`, | |||
| match: `(?<=\\()\\s*(using)\\s+(?=[\\w\\d\\(\\.\\(\\{'"$])`, | |||
There was a problem hiding this comment.
Is there a reason for why we have the positive lookahead (?=[\\w\\d\\(\\.\\(\\{'"])?
I'm also noticing here that we have \\( twice in the character set [\\w\\d\\(\\.\\(\\{'"$].
Also, could some of these be un-escaped? I think ( and { don't need to be escaped in character sets.
There was a problem hiding this comment.
The positive lookahead seems to be there for historical reasons. I simplified the regex to not use it at all and added some tests for the cases the lookahead was trying to avoid.
nicolasstucki
force-pushed
the
fix-#180
branch
from
5b7e6c7 to
0de97c8
Compare
nicolasstucki
force-pushed
the
fix-#180
branch
from
0de97c8 to
f8dcd02
Compare
MaximeKjaer
approved these changes
Jan 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.