Identify quotes/splices start as the start of a normal block #176
Conversation
| }, | ||
| { // Start of `'[ .. ]` | ||
| match: "'\\[(?!')", | ||
| name: 'meta.bracket.scala' |
There was a problem hiding this comment.
Is there a reason that '{ and '[ are assigned such different tokens? Also, I don't understand why ' and { have different colors on my machine, even though the tests show that they should be the same token. Does this also happen on your machine, or is mine somehow misconfigured?
There was a problem hiding this comment.
We need to identify those tokens separately or it would try the Char tokens. I chose the block as highlighting to make sure the start and end are highlighted the same way.
With this change, I am aiming to fix the inconsistency seen in GitHub.
In my setup, I actually saw the old and new version in white. It is really strange that you see it differently. Are you sure you have the correct version installed locally? I remember that when trying to install a local plugin with a lower version vscode just ignored it and kept the old one.
I will experiment with different colors for vscode to see if I have something similar.
There was a problem hiding this comment.
I did fight a little with my vscode setup to make sure I had the right version installed, but I think I eventually did.
If you want to try my colors, I'm using the "Material Theme" by Mattia Astorino, with the Material Theme High Contrast theme.
There was a problem hiding this comment.
I do get consistently the expected highlighting with different configs and on two different machines. It is probably an issue with your setup.
There was a problem hiding this comment.
Okay, in that case I'll approve and merge. Thank you for looking into it.
No description provided.