Skip to content

Add auto-closing pair settings for string interpolation #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 22, 2019
Merged

Add auto-closing pair settings for string interpolation #16

merged 1 commit into from
Mar 22, 2019

Conversation

hugo-vrijswijk
Copy link
Contributor

@hugo-vrijswijk hugo-vrijswijk commented Mar 22, 2019

I've added auto-closing pairs for all out-of-the-box supported String interpolators (s, f & raw).

Previously, when typing s" no extra " would be added. Typing another " would result in s""" (three quotes).

Now when s" is typed, the result is s"", with the cursor between the quotes

Before

After

Copy link
Contributor

@olafurpg olafurpg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this contribution! LGTM 👍 What do you think @nicolasstucki ?

@nicolasstucki nicolasstucki merged commit ba18577 into scala:master Mar 22, 2019
@hugo-vrijswijk hugo-vrijswijk deleted the patch-1 branch March 22, 2019 15:00
@nicolasstucki
Copy link
Contributor

Thanks @hugo-vrijswijk

@torkelrogstad torkelrogstad mentioned this pull request Apr 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants