-
Notifications
You must be signed in to change notification settings - Fork 37
Improve contributing guide and workflow #114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
ba8ce0c
8ad52d0
28089f6
c7d3c9d
d751b0e
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -44,16 +44,20 @@ | |
"devDependencies": { | ||
"@types/node": "^14.0.14", | ||
"ajv": "^6.12.2", | ||
"npm-run-all": "^4.1.5", | ||
"ts-node": "^8.10.2", | ||
"tsc": "^1.20150623.0", | ||
"typescript": "^3.9.5", | ||
"vsce": "^1.77.0", | ||
"vscode-tmgrammar-test": "0.0.10" | ||
}, | ||
"scripts": { | ||
"vscode:prepublish": "test -f ./syntaxes/Scala.tmLanguage.json", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I don't think this There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @MaximeKjaer , it just checks if the file |
||
"vscode:publish": "vsce publish --yarn", | ||
"build": "ts-node src/typescript/GenerateTmLanguageFile.ts > ./syntaxes/Scala.tmLanguage.json", | ||
"test": "node scripts/unit.js && node scripts/snap.js" | ||
"build": "npm-run-all build:syntax build:extension", | ||
"build:syntax": "ts-node src/typescript/GenerateTmLanguageFile.ts > ./syntaxes/Scala.tmLanguage.json", | ||
"build:extension": "vsce package", | ||
"test": "npm-run-all test:*", | ||
"test:unit": "vscode-tmgrammar-test -s source.scala -g syntaxes/Scala.tmLanguage.json -t 'tests/unit/**/*.test.scala'", | ||
"test:snap": "vscode-tmgrammar-snap -s source.scala -g syntaxes/Scala.tmLanguage.json -t 'tests/snap/**/*.test.scala'" | ||
} | ||
} |
This file was deleted.
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When is
yarn build:extension
executed? Is that part ofyarn vscode:publish
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes it is. From the vsce docs it seems that
yarn vscode:publish
(akavsce publish
) does the packaging before publishing, as it is the only command needed to publish.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok