Skip to content

Invalid coloring of closing paren/brace after with clause #77

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
kubukoz opened this issue Feb 24, 2020 · 1 comment · Fixed by #89
Closed

Invalid coloring of closing paren/brace after with clause #77

kubukoz opened this issue Feb 24, 2020 · 1 comment · Fixed by #89
Labels
bug Something isn't working
Milestone
0.4.0

Comments

@kubukoz
Copy link

kubukoz commented Feb 24, 2020

Example:

image

Expected:

image

(minus the space, of course)

The same happens if the parentheses are {} braces.

Source: https://github.com/typelevel/cats-effect/blob/v2.1.1/core/shared/src/main/scala/cats/effect/Concurrent.scala#L618
@kubukoz
Copy link
Author

kubukoz commented Feb 24, 2020

#68 seems to be related.

nicolasstucki added a commit to nicolasstucki/vscode-scala-syntax that referenced this issue Jun 26, 2020
@nicolasstucki
Fix scala#68 and fix scala#77: End names on open brackets
dc54ded
@nicolasstucki nicolasstucki linked a pull request Jun 26, 2020 that will close this issue
Fix #68 and fix #77: End names on open brackets #89
Merged
@nicolasstucki nicolasstucki added this to the 0.4.0 milestone Jun 29, 2020
@nicolasstucki nicolasstucki added the bug Something isn't working label Jun 29, 2020
anatoliykmetyuk pushed a commit that referenced this issue Jun 29, 2020
@nicolasstucki @anatoliykmetyuk
Fix #68 and fix #77: End names on open brackets
f13e740
nicolasstucki added a commit to nicolasstucki/vscode-scala-syntax that referenced this issue Jun 29, 2020
@nicolasstucki
Fix scala#68 and fix scala#77: End names on open brackets
05a24a6
nicolasstucki added a commit that referenced this issue Jun 29, 2020
@nicolasstucki
Merge pull request #89 from nicolasstucki/fix-#68
5f79e18 
Fix #68 and fix #77: End names on open brackets
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
0.4.0
Development

Successfully merging a pull request may close this issue.

Fix #68 and fix #77: End names on open brackets nicolasstucki/vscode-scala-syntax
2 participants
@kubukoz @nicolasstucki