-
Notifications
You must be signed in to change notification settings - Fork 37
Do not depend on github-changes #45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
We only use it here vscode-scala-syntax/bin/ci-release.sh Line 31 in 17a7bdb
|
This code was copied from @gabro do you remember what this command did exactly? I wonder if there is a newer library that would do the same. |
@nicolasstucki that command generates https://github.com/scalameta/metals-vscode/blob/master/CHANGELOG.md The library was picked arbitrarily (literally the first one that did the job I needed) so there may be newer alternatives. That said, the library is not even used by the plugin, so you can avoid the security warning by removing the dependency and installing it ad-hoc in the CI. Something like:
|
Fix #45: Use npx to execute github-changes
Revert "Fix #45: Use npx to execute github-changes"
This reverts commit 14d22e4.
Revert "Revert "Fix #45: Use npx to execute github-changes""
Last version was published 2 years ago and it has transitive dependencies that have security warnings .
https://www.npmjs.com/package/github-changes
The text was updated successfully, but these errors were encountered: