Skip to content

Illegal $ in string interpolator could be highlighted as an illegal token #195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
nicolasstucki opened this issue Jan 29, 2021 · 0 comments · Fixed by #196
Closed

Illegal $ in string interpolator could be highlighted as an illegal token #195

nicolasstucki opened this issue Jan 29, 2021 · 0 comments · Fixed by #196
Labels
enhancement New feature or request

Comments

@nicolasstucki
Copy link
Contributor

Screenshot 2021-01-29 at 13 41 08
@nicolasstucki nicolasstucki added the enhancement New feature or request label Jan 29, 2021
nicolasstucki added a commit to nicolasstucki/vscode-scala-syntax that referenced this issue Jan 29, 2021
@nicolasstucki
Identify illegal $ tokens in string interpolators
f6f1338 
Fixes scala#195

Scala 2 stops parsing after one of these failures. It does not mather how we highlight the rest.

Scala 3 continues parsing assuming the string has been closed. Highlighting the following code as if the string was closed helps to understand the following parsing errors.
nicolasstucki added a commit to nicolasstucki/vscode-scala-syntax that referenced this issue Jan 29, 2021
@nicolasstucki
Identify illegal $ tokens in string interpolators
6d3de7b 
Fixes scala#195

Scala 2 stops parsing after one of these failures. It does not matter how we highlight the rest.

Scala 3 continues parsing assuming the string has been closed. Highlighting the following code as if the string was closed helps to understand the following parsing errors.
@nicolasstucki nicolasstucki mentioned this issue Jan 29, 2021
Merged
PanAeon pushed a commit to PanAeon/vscode-scala-syntax that referenced this issue Apr 28, 2022
@nicolasstucki @PanAeon
Identify illegal $ tokens in string interpolators
ab7e4c8 
Fixes scala#195

Scala 2 stops parsing after one of these failures. It does not matter how we highlight the rest.

Scala 3 continues parsing assuming the string has been closed. Highlighting the following code as if the string was closed helps to understand the following parsing errors.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Identify illegal $ tokens in string interpolators nicolasstucki/vscode-scala-syntax
1 participant
@nicolasstucki