Import Highlighting

[nickhudkins]

I am slowly trying to move to VS Code for my Scala development, but one thing that still stands out to me is the lack of highlighting within imports. This is only relevant because I am coming from Intelli-J where the highlighting of imports is far more verbose.

I have never worked on a syntax highlighting project, but am happy to dig in if this is a desired change!

Thanks for all of the work, this is an incredible improvement to my computer's battery life and fan noise 🤣

[PanAeon]

Hi @nickhudkins,

The class highlighting could be easily done by matching first uppercase character. But for others stuff I think Intellij uses semantic highlighting. I.e. it runs the code against actual scala parser and its own version of presentation compiler to get methods, objects and interfaces.

This project uses regex rules to get token information so atm it's impossible to distinguish for example between class Foo and interface Bar if there's no additional context, that is keyword trait before the interface name.

If you need that kind of highlighting you can check vscode tree sitter plugin. But it's in the preview stage and might not work as expected.

Also there's a semantic highlighting for vscode spec, which might be implemented by metals for example, but it is not finalized if I'm not mistaken.

[nicolasstucki]

This is the best we can do with syntactic highlighting

[nickhudkins]

@PanAeon and @nicolasstucki, thanks so much for the explanation :) You've resolved my concerns, and it looks like @nicolasstucki already has a PR open to make an improvement here!

[nicolasstucki]

Yes, I just edited that pattern a couple of days ago an knew exactly what to do.