Skip to content

Colon opening a template at end of name has same colour #104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
bishabosha opened this issue Jun 29, 2020 · 1 comment · Fixed by #108
Closed

Colon opening a template at end of name has same colour #104

bishabosha opened this issue Jun 29, 2020 · 1 comment · Fixed by #108
Labels
bug Something isn't working Scala 3

Comments

@bishabosha
Copy link
Member 

class Foo: // shares colour of stable identifier
  def foo = 23

class Bar : // has same colour as declarations
  def bar = 37
@nicolasstucki
Copy link
Contributor

We need to be careful with this one. Consider the definition of :: and *:.

trait *: :
  def a = ...
trait :: :
  def a = ...

@nicolasstucki nicolasstucki added bug Something isn't working Scala 3 labels Jun 30, 2020
nicolasstucki pushed a commit to nicolasstucki/vscode-scala-syntax that referenced this issue Jun 30, 2020
@nicolasstucki
Fix scala#104: Distinguish open declaration :
5404b87
@nicolasstucki nicolasstucki linked a pull request Jun 30, 2020 that will close this issue
Fix #104: Distinguish open declaration : #108
Merged
anatoliykmetyuk added a commit that referenced this issue Jul 1, 2020
@anatoliykmetyuk
Merge pull request #108 from nicolasstucki/fix-#104
857a792 
Fix #104: Distinguish open declaration `:`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working Scala 3
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #104: Distinguish open declaration : nicolasstucki/vscode-scala-syntax
2 participants
@nicolasstucki @bishabosha