Fix #141: Remove old extension on syntax

Author: nicolasstucki

src/typescript/Scala.tmLanguage.ts

@@ -1008,21 +1008,7 @@ export const scalaTmLanguage: TmLanguage = {
     extension: {
       patterns: [
         {
-          match: `(extension)\\s+(?:(${plainid})\\s)?\\s*(on|(?=\\{))`,
-          captures: {
-            '1': {
-              name: 'keyword.declaration.scala'
-            },
-            '2': {
-              name: 'entity.name.class'
-            },
-            '3': {
-              name: 'keyword.declaration.scala'
-            }
-          }
-        },
-        {
-          match: `(extension)\\s+(?=[\\[\\(])`,
+          match: `^\\s*(extension)\\s+(?=[\\[\\(])`,
           captures: {
             '1': {
               name: 'keyword.declaration.scala'

tests/unit/#141.test.scala

@@ -0,0 +1,10 @@
+// SYNTAX TEST "source.scala"
+
+val language = file.extension {
+//                  ^^^^^^^^^ - keyword.declaration.scala
+val language = file extension {
+//                  ^^^^^^^^^ - keyword.declaration.scala
+val language = file.extension(
+//                  ^^^^^^^^^ - keyword.declaration.scala
+val language = file extension (
+//                  ^^^^^^^^^ - keyword.declaration.scala

tests/unit/extension-on.test.scala

@@ -1,23 +1,25 @@
 // SYNTAX TEST "source.scala"
 
+// Old syntax is not supported anymore. We make sure that it is not accidentally highlighted.
+
     extension on (x: Rational):
-//  ^^^^^^^^^ keyword.declaration.scala
-//            ^^ keyword.declaration.scala
+//  ^^^^^^^^^ - keyword.declaration.scala
+//            ^^ - keyword.declaration.scala
 //                ^ variable.parameter.scala
 //                   ^^^^^^^^ entity.name.class
        def > (y: Rational): Boolean = y < x
 
    extension Ops on (x: Rational):
-// ^^^^^^^^^ keyword.declaration.scala
+// ^^^^^^^^^ - keyword.declaration.scala
 //           ^^^ entity.name.class
-//               ^^ keyword.declaration.scala
+//               ^^ - keyword.declaration.scala
 //                   ^ variable.parameter.scala
 //                      ^^^^^^^^ entity.name.class
       def > (y: Rational): Boolean = y < x
 
    extension stringOps {  }
-// ^^^^^^^^^ keyword.declaration.scala
-//           ^^^^^^^^^ entity.name.class
+// ^^^^^^^^^ - keyword.declaration.scala
+//           ^^^^^^^^^ - entity.name.class
 
    extension {  }
-// ^^^^^^^^^ keyword.declaration.scala
+// ^^^^^^^^^ - keyword.declaration.scala