Add Reflection Symbol docs #9983
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liufengyun
reviewed
Oct 12, 2020
| @@ -2679,14 +2679,30 @@ trait Reflection { reflection => | |||
| /** Annotations attached to this symbol */ | |||
| def annots: List[Term] | |||
|
|
|||
| /** Does this symbol come from a currently compiled source file? */ | |||
| def isDefinedInCurrentRun: Boolean | |||
There was a problem hiding this comment.
This can be potentially ambiguous, as now the compiler may compile a batch of files in multiple runs to support macros.
liufengyun
reviewed
Oct 12, 2020
| def isDefinedInCurrentRun: Boolean | ||
|
|
||
| /** Dummy val symbol that owns all statements within the initialization of the class. | ||
| * This may also contain local definitions such as classes defined in a `locally` block in the class. | ||
| */ | ||
| def isLocalDummy: Boolean |
There was a problem hiding this comment.
Regarding isLocalDummy and isRefinementClass, it would be better to not provide them if they are not useful in practice, as they involve implementation details that might change.
There was a problem hiding this comment.
We should see if we can have an alternative design. We cannot return the owner of the local dummy as that would be ambiguous.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.