Fix #9967: Don't add forwarders for super accessors #9978
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Super accessors are flagged as Artifact in dotty, but not in nsc. So We need to weed them out separately when creating export forwarders.
smarter
reviewed
Oct 10, 2020
| && mbr.matchesImportBound(if mbr.symbol.is(Given) then givenBound else wildcardBound) | ||
| then addForwarder(alias, mbr, span) | ||
| if !mbr.symbol.isSuperAccessor then | ||
| // Scala 2 superaccessors have neither Synthetic nor Artfact set, so we |
There was a problem hiding this comment.
Alternatively I guess we could set these flags for superaccessors in Scala2Unpickler, that way we're sure they're treated like the dotty ones.
There was a problem hiding this comment.
I'd consider that if we find other areas where the missing flag for super accessors messes things up. As it is now, we exercise the test a lot less often than if we have to test every symbol read from Scala 2 for whether it is a super accessor.
smarter
approved these changes
Oct 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Super accessors are flagged as Artifact in dotty, but not in nsc. So
We need to weed them out separately when creating export forwarders.