Enable Scala.js test #9973
Merged
Enable Scala.js test #9973
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The process pool is only needed for run tests.
Co-authored-by: Sébastien Doeraene <[email protected]>
As mentioned in [1]: > JUnit creates a new instance of the test class before invoking each > @test method. This helps provide independence between test methods and > avoids unintentional side effects in the test code. Because each test > method runs on a new test class instance, we can’t reuse instance > variable values across test methods. Each `@Test` method would create a new instance of the test classes, which means each `@Test` method would create N new processes. [1]: https://stackoverflow.com/questions/14010222/junit-new-instance-before-invoking-each-test-method-what-are-the-benefits
The test result differ. Need to investigate and enable later.
anatoliykmetyuk
approved these changes
Oct 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable Scala.js test