Fix #9755: Add tests for Scala.js top-level native members #9951
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dottybot
reviewed
Oct 6, 2020
adpi2
force-pushed
the
sjs-top-level-native-defs
branch
2 times, most recently
from
b709e59 to
6d9940c
Compare
sjrd
requested changes
Oct 6, 2020
tests/sjs-junit/test/org/scalajs/testsuite/jsinterop/TopLevelNativeJSMembersTestScala3.scala
Outdated
Show resolved
Hide resolved
adpi2
changed the title
adpi2
force-pushed
the
sjs-top-level-native-defs
branch
from
6d9940c to
e583ee8
Compare
sjrd
approved these changes
Oct 6, 2020
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9755
It would require more infrastructure work to check that the Scala.js linker can link the native members to actual node.js modules.