Skip to content

Change implicit conversions warnings #9935

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

odersky
Copy link
Contributor

@odersky odersky commented Oct 2, 2020

Warn with a feature warning if

  • an old-style implicit def conversion is defined, or
  • a new style scala.Conversion instance is used as an implicit conversion

Do not warn if an old-style conversion is used. There are too many warnings
for this to work well. Instead, rely on the fact that old-style implicit
conversions will be deprecated over time.

Warn with a feature warning if

 - an old-style implicit def conversion is defined, or
 - a new style scala.Conversion instance is used as an implicit conversion

Do not warn if an old-style conversion is used. There are too many warnings
for this to work well. Instead, rely on the fact that old-style implicit
conversions will be deprecated over time.
@odersky odersky requested a review from liufengyun October 2, 2020 13:09
@odersky odersky added this to the 3.0.0-M1 milestone Oct 2, 2020
Copy link
Contributor

@liufengyun liufengyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@liufengyun liufengyun merged commit 4b8a1de into scala:master Oct 5, 2020
@liufengyun liufengyun deleted the change-implicit-conversion-warning branch October 5, 2020 06:04
@Kordyjan Kordyjan modified the milestones: 3.0.0-M1, 3.0.0 Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants