Optimize typeSymbol and classSymbol #9887
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odersky
force-pushed
the
optimize-widening
branch
3 times, most recently
from
b20b8f0 to
b6c139a
Compare
typeSymbol now follows underlying type for SingletonTypes, same as for other TypeProxys.
The dropped condition is vacuously true for all singleton prefixes, since for them classSymbol is NoSymbol. If we make it work as was intended using widen in front of classSymbol on both sides, then EeraseAnd and dotty bootstrap fail.
Analogius to the change for typeSymbol
odersky
force-pushed
the
optimize-widening
branch
from
b6c139a to
9ff3203
Compare
|
test performance please |
|
performance test scheduled: 2 job(s) in queue, 1 running. |
|
Performance test finished successfully: Visit http://dotty-bench.epfl.ch/9887/ to see the changes. Benchmarks is based on merging with master (8a9e0e9) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make typeSymbol and classSymbol also work for Singleton types by going to
the underlying type. Previously, they returned NoType.
Changing this behavior makes code shorter and removes a common pitfall.