Refactor Reflection reporting #9864
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolasstucki
force-pushed
the
refactor-reflection-reporting
branch
from
864fe17 to
26a5798
Compare
|
@liufengyun Ill update the community build once we settled on the definitive naming. |
nicolasstucki
force-pushed
the
refactor-reflection-reporting
branch
from
26a5798 to
3eb1dea
Compare
liufengyun
approved these changes
Oct 6, 2020
There was a problem hiding this comment.
LGTM
I see this is more consistent with the overall API style. However, from the perspective of meta-programmers, this does not seem to improve the friendliness of the API, as it introduces more names that programmers have to learn/remember in order to use the same functionality.
However, consistency is more important and the impact on usability is minor. Meanwhile, it's better to break existing Scala 3 macro code earlier than later.
nicolasstucki
force-pushed
the
refactor-reflection-reporting
branch
from
3eb1dea to
e27ddb7
Compare
nicolasstucki
force-pushed
the
refactor-reflection-reporting
branch
from
e27ddb7 to
5315f08
Compare
|
I updated the community projects |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.