Skip to content

fix #9766: extensions cannot be extension_foo #9854

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 23, 2020
Merged

fix #9766: extensions cannot be extension_foo #9854

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion compiler/src/dotty/tools/dotc/ast/Desugar.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -945,7 +945,7 @@ object desugar {
report.error(IllegalRedefinitionOfStandardKind(kind, name), errPos)
name = name.errorName
}
if name.isExtensionName && !mdef.mods.is(ExtensionMethod) then
if name.isExtensionName && (!mdef.mods.is(ExtensionMethod) || name.dropExtension.isExtensionName) then
report.error(em"illegal method name: $name may not start with `extension_`", errPos)
name
}
Expand Down
2 changes: 2 additions & 0 deletions tests/neg/illegal-extension.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
trait A {
def extension_n: String = "illegal method" // error: illegal method name: extension_n may not start with `extension_`
}

extension (x: Any) def extension_foo: String = "foo" // error: illegal method name: extension_foo may not start with `extension_`