Add test for dotc.core pickling/unpickling #985
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VladimirNik
force-pushed
the
tasty-core-test
branch
from
f2227d8 to
a6713ed
Compare
|
/rebuild |
1 similar comment
|
/rebuild |
VladimirNik
force-pushed
the
tasty-core-test
branch
6 times, most recently
from
94a30cc to
0a01310
Compare
| @@ -230,6 +230,40 @@ class tests extends CompilerTest { | |||
| @Test def tasty_dotc_printing = compileDir(dotcDir, "printing", testPickling) | |||
| //@Test def tasty_dotc_reporting = compileDir(dotcDir, "reporting", testPickling) | |||
| @Test def tasty_dotc_util = compileDir(dotcDir, "util", testPickling) | |||
| @Test def tasty_core_annotations = compileFile(coreDir, "Annotations", testPickling) | |||
There was a problem hiding this comment.
instead of having a test per file, would you consider using compileList to test them all together?
There was a problem hiding this comment.
@DarkDimius fixed
|
Otherwise LGTM |
VladimirNik
force-pushed
the
tasty-core-test
branch
from
0a01310 to
0c970b1
Compare
|
LGTM |
DarkDimius
added a commit
that referenced
this pull request
Dec 2, 2015
Add test for dotc.core pickling/unpickling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests for doc.core pickling/unpickling:
dotc.core
dotc.core.tasty
dotc.core.classfile
dotc.core.unpickleScala2
core/Types.scala is not presented in tests because Types contains transformed OR type after unpickling.
Review by @DarkDimius