Remove Reflection StandardTypes #9815
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that the inspector provides the quote context, the interpreter can also use it
All these can be replaced by a call to `Type.of[XYZ]`. We added them before we had a mechanism to get arbitrary types, now it became redundant. These methods where more performant than the `Type.of` variant. We already oprimize primitive types for `Type.of` and could do it for other types when the need arises.
nicolasstucki
force-pushed
the
remove-reflection-standard-types
branch
from
3d47e79 to
9f64cc1
Compare
liufengyun
approved these changes
Sep 17, 2020
| qctx.tasty.defn.DoubleType.seal.asInstanceOf[quoted.Type[Double]] | ||
| val qctx1 = quoteContextWithCompilerInterface(qctx) | ||
| qctx1.tasty.Definitions_DoubleType.seal.asInstanceOf[quoted.Type[Double]] | ||
|
|
There was a problem hiding this comment.
Can we do the same for Type.Int, etc as in Reflection.Type?
There was a problem hiding this comment.
That definition is not visible in the public API. It is used as an optimization of '[Int]. I'm looking for other ways to optimize it differently but it will take some time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All these can be replaced by a call to
Type.of[XYZ].We added them before we had a mechanism to get arbitrary types, now it became redundant.
These methods where more performant than the
Type.ofvariant. We already oprimize primitive types forType.ofand could do it for other types when the need arises.Migration
Replace
defn.XYZTypewithType.of[XYZ](useful regex\bdefn\.(\w+)Type\b->Type.of[$1]).