Skip to content

Fix #9802: Interpret by-name params as () => interpret(arg) #9811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 17, 2020
Merged

Fix #9802: Interpret by-name params as () => interpret(arg) #9811

merged 1 commit into from
Sep 17, 2020

Conversation

nicolasstucki
Copy link
Contributor

No description provided.

@nicolasstucki nicolasstucki linked an issue Sep 17, 2020 that may be closed by this pull request
By-name on Macro implementation crashes compiler #9802
Closed
@nicolasstucki nicolasstucki marked this pull request as ready for review September 17, 2020 08:46
liufengyun
liufengyun approved these changes Sep 17, 2020
View reviewed changes
Copy link
Contributor

@liufengyun liufengyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nicolasstucki
Copy link
Contributor Author

I added a test for by name context functions and fixed the logic that handles those arguments.

@nicolasstucki nicolasstucki merged commit e5a789b into scala:master Sep 17, 2020
@nicolasstucki nicolasstucki deleted the fix-#9802 branch September 17, 2020 14:35
@Kordyjan Kordyjan added this to the 3.0.0 milestone Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liufengyun liufengyun liufengyun approved these changes

Assignees

@liufengyun liufengyun

Labels
None yet
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.

By-name on Macro implementation crashes compiler
3 participants
@nicolasstucki @liufengyun @Kordyjan