Rename reflection Class[?] to Type conversion
#9798
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolasstucki
force-pushed
the
rename-reflection-classof-type
branch
from
3bfe7a0 to
0d2c851
Compare
|
Based on #9797 |
nicolasstucki
force-pushed
the
rename-reflection-classof-type
branch
from
0d2c851 to
73944a2
Compare
sjrd
reviewed
Sep 15, 2020
| * | ||
| * See `Type.of` to get the true type. | ||
| */ | ||
| def ofErasedClass(clazz: Class[_])(using ctx: Context): Type = |
There was a problem hiding this comment.
Is this actually used by anything else than scala.quoted.ClassLiftable? If not, could we make it private[scala] unless and until we discover an imperative use case outside?
There was a problem hiding this comment.
I don't see any uses outside lifting arrays
nicolasstucki
force-pushed
the
rename-reflection-classof-type
branch
from
73944a2 to
c095fab
Compare
We only require this type representation to be able to lift and handle generic arrays. We will use this internally only as long as no real use case for this functionality appears.
nicolasstucki
force-pushed
the
rename-reflection-classof-type
branch
from
c095fab to
c9de0e1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.