Cache more implicit scopes #9747
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
test performance please |
|
performance test scheduled: 2 job(s) in queue, 1 running. |
|
Performance test finished successfully: Visit http://dotty-bench.epfl.ch/9747/ to see the changes. Benchmarks is based on merging with master (101e620) |
Also cache implicit scopes that arise from types that map to a different lifted type.
odersky
force-pushed
the
cache-iscopes
branch
from
e207876 to
3f873ec
Compare
|
Shows an improvement of 5% for Dotty. I don't think the other full compilation benchmarks use implicits much, so I would not expect them to be much affected. |
liufengyun
approved these changes
Sep 8, 2020
| if (tp.hash == NotCached) computeEligible(tp) | ||
| if (tp.hash == NotCached) | ||
| Stats.record(i"compute eligible not cached ${tp.getClass}") | ||
| Stats.record(i"compute eligible not cached") |
There was a problem hiding this comment.
Suggested change
| Stats.record(i"compute eligible not cached") |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also cache implicit scopes that arise from types that map to a different
lifted type.