Skip to content

Remove constraints abstraction from Context #9710

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

nicolasstucki
Copy link
Contributor

The constraints API is available durring the execution of the Matcher and initialized before the matching strats independently of the local contexts in the Matcher.

@nicolasstucki nicolasstucki changed the title Remove-constraints abstraction from Context Remove constraints abstraction from Context Sep 2, 2020
@nicolasstucki nicolasstucki force-pushed the remove-constraints-abstraction-from-context branch from 5a9d5d2 to 485e503 Compare September 2, 2020 15:41
@nicolasstucki nicolasstucki self-assigned this Sep 2, 2020
@nicolasstucki
Copy link
Contributor Author

Factored out of #9634

The constraints API is available durring the execution of the Matcher and initialized before the matching strats independently of the local contexts in the Matcher.
@nicolasstucki nicolasstucki force-pushed the remove-constraints-abstraction-from-context branch from 485e503 to 8106cc9 Compare September 3, 2020 07:00
@nicolasstucki nicolasstucki marked this pull request as ready for review September 3, 2020 08:24
Copy link
Contributor

@liufengyun liufengyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nicolasstucki nicolasstucki merged commit 5ea8694 into scala:master Sep 3, 2020
@nicolasstucki nicolasstucki deleted the remove-constraints-abstraction-from-context branch September 3, 2020 09:29
@Kordyjan Kordyjan added this to the 3.0.0 milestone Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants