fix #9260 - Enums copy variance of parent #9709
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bishabosha
changed the title
smarter
reviewed
Sep 2, 2020
bishabosha
force-pushed
the
topic/enum-unification
branch
from
a26cebe to
8e7a59c
Compare
bishabosha
force-pushed
the
topic/enum-unification
branch
from
8e7a59c to
a126ebf
Compare
smarter
reviewed
Sep 7, 2020
smarter
reviewed
Sep 7, 2020
smarter
reviewed
Sep 7, 2020
bishabosha
force-pushed
the
topic/enum-unification
branch
from
27919fb to
99a6e2b
Compare
bishabosha
force-pushed
the
topic/enum-unification
branch
from
99a6e2b to
b1c490a
Compare
smarter
reviewed
Sep 7, 2020
| TypeDef(sym.name, DerivedFromParamTree().watching(sym)).withFlags(TypeParam) | ||
| def derivedTypeParamWithVariance(sym: TypeSymbol)(using Context): TypeDef = | ||
| val variance = VarianceFlags & sym.flags | ||
| TypeDef(sym.name, DerivedFromParamTree().watching(sym)).withFlags(TypeParam | Synthetic | variance) |
There was a problem hiding this comment.
For consistency, we should probably set Synthetic on the other derivedTypeParam and on derivedTermParam assuming that doesn't break things.
There was a problem hiding this comment.
If I add synthetic flag in derivedTermParam it changes the positions in this test: https://github.com/lampepfl/dotty/blob/ce48f5a2c79373f8a33ced1d251de0206ed5cba9/language-server/test/dotty/tools/languageserver/DefinitionTest.scala#L182
There was a problem hiding this comment.
yeah so maybe it's not worth it, what does it change the position to?
There was a problem hiding this comment.
from line 0-15:16 to line 0-11:14
There was a problem hiding this comment.
is this worth investigating in this PR?
smarter
approved these changes
Sep 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
previously, the interpolated type parameters for a class enum case would forget the flags of the copied type parameter, now we copy the intersection of its flags with the variance flags
fixes #9260