Skip to content

Re-use contexts when changing owners in MegaPhase #9659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 1, 2020

Conversation

odersky
Copy link
Contributor

@odersky odersky commented Aug 27, 2020

Use a context stack similar to explore and comparing. This can be done in more places
but the hottest spot was in MegaPhase, so it's first done there.

Use a context stack similar to explore and comparing. This can be done in more places
but the hottest spot was in MegaPhase, so it's first done there.
@odersky
Copy link
Contributor Author

odersky commented Aug 29, 2020

test performance please

@dottybot
Copy link
Member

performance test scheduled: 1 job(s) in queue, 1 running.

@dottybot
Copy link
Member

Performance test finished successfully:

Visit http://dotty-bench.epfl.ch/9659/ to see the changes.

Benchmarks is based on merging with master (4c99388)

Copy link
Contributor

@liufengyun liufengyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@odersky odersky merged commit b0c4f33 into scala:master Sep 1, 2020
@odersky odersky deleted the optimize-change-owner branch September 1, 2020 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants