Re-enable parallel pickling #9650
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odersky
force-pushed
the
parallel-pickling
branch
from
c01c96e to
4ecb501
Compare
|
OK, so I did re-run the jobs 4 times. Nothing acted up. I propose we merge but only after the next release is cut. /cc @anatoliykmetyuk |
smarter
reviewed
Aug 27, 2020
| println(new TastyPrinter(pickled).printContents()) | ||
| } | ||
| pickled | ||
| }(using ExecutionContext.global) |
There was a problem hiding this comment.
This isn't urgent but instead of hardcoding the ExecutionContext we should probably get it from the Context to allow it to be customized by the build tool if it uses a different thread pool, etc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both position and comment pickler accessed symbols in trees. Position pickler also accessed denotations through symbols.
This is a potential race since both operations depend on phase-indexed caches, which are not protected.
We now avoid the problem by pre-computing everything position and comment pickler need from symbols, and passing it separately to them. Neither position nor tree pickler takes a context anymore, which means they cannot possibly interfere
with the rest -- or, rather, they can interfere only through global variables, the same way a parallel compiler testing thread does. But we have that well under control through the existing static race detection mechanism.