Fix #9642: Revert "Port classpath improvements" #9643
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liufengyun
reviewed
Aug 26, 2020
|
As long as the problem can be fixed quickly, sure. In the meantime, I cannot do anything in this codebase. |
I'll propose a quick fix soon (could be longer as I don't have a windows Env). Does it work if you revert it locally and later drop the revert & rebase when we have a fix? If that's too much hassle, we can merge this first, and double revert it with a fix for windows. |
It's annoying but yes, this is what I'll do if I run out of other things to deal with today before this is fixed. |
|
Merge this now, the proper fix needs more time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #9615