Fix ambiguity errors with polymorphic implicits #963
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smarter
force-pushed
the
fix/poly-implicits
branch
4 times, most recently
from
f82d840 to
64a577a
Compare
Previously, `isAsSpecific(alt1, tp1, alt2, tp2)` did not handle having `tp2` be a polymorphic non-method type like `[A]Foo[A]`. Also update the documentation of `isAsSpecific` to account for this change, the new documentation is based on SLS § 6.26.3 but adapted to reflect the code.
Also reorder the cases to be in the same order as the documentation.
smarter
force-pushed
the
fix/poly-implicits
branch
from
64a577a to
c2079f2
Compare
smarter
added a commit
that referenced
this pull request
Nov 18, 2015
Fix ambiguity errors with polymorphic implicits
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously,
isAsSpecific(alt1, tp1, alt2, tp2)did not handlehaving
tp2be a polymorphic non-method type like[A]Foo[A].Also update the documentation of
isAsSpecificto account for thischange, the new documentation is based on SLS § 6.26.3 but
adapted to reflect the code.
Review by @odersky