Optimize toBits in FlagSet #9609
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
async-profiles have shown that toBits was not inlined by the JVM. Helping the JVM a bit here by making bits inline, so that toBits is one fewer call away. Not that we cannot inline toBits at typer since it is in the scope of an opaque type.
|
test performance please |
|
performance test scheduled: 15 job(s) in queue, 1 running. |
|
Performance test finished successfully: Visit http://dotty-bench.epfl.ch/9609/ to see the changes. Benchmarks is based on merging with master (1431be2) |
|
This did improve re2 (from where the profile came from) and also dotty. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
async-profiles have shown that toBits was not inlined by the JVM. Helping the JVM a bit here by
making bits inline, so that toBits is one fewer call away.
Not that we cannot inline toBits at typer since it is in the scope of an opaque type.