Update reference compiler #9606
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolasstucki
force-pushed
the
update-reference-compiler-2
branch
5 times, most recently
from
8fee998 to
1751294
Compare
|
I don't know why the bootstrap problem arose but I have a fix for it. I'll add another commit. |
nicolasstucki
force-pushed
the
update-reference-compiler-2
branch
from
1751294 to
7f3c13c
Compare
The previously optimized apply function was not tail recursive since it was not final.
|
@odersky the bootstrap problem was failing correctly where it should but as it had an un-informative error message it made it harder to fix. Then while trying to fix it a bit blindly I moved some files from src-bootstrapped to src but missed the fact that one of those had changed between the latest nightly and the moment I started this PR. If we would have made this PR tomorrow it would have been simpler to not fall into this trap. In the future, we should probably avoid re-bootstrapping the compiler if there was some change in the library that same day to avoid extra work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.