Fix #941 #960
Merged
Fix #941 #960
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make secondary constructor type parameters aliases of the enclosing class parameters. Test case in i941.scala. Observed in the wild when trying to typecheck Streams.scala.
If `x` is not a function or method, then `x _` should be disallowed. scalac accepts this and converts it to () => x instead. I'd like to drop this because it's unnecessary and non-obvious. If -language:Scala2 is on, the behavior is like Scala 2's but a migration warning is issued.
Flag them as "migration warning" rather than just "warning".
The previous test was too struct, missed cases where some arguments of the function were unbound. i583a.scala contains a test case.
Linearize instead. It would be nice to be able to give a migration warning here, but unfortunately we do not have a position at the point the warning would be generated, and it feels like overkill to do another kind of exception that gets propagated and caught in typer.
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #941 and #942. Review by @VladimirNik ?