Avoid creating unnecessary strings in adjustExtension #9598
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # compiler/src/dotty/tools/dotc/typer/Typer.scala
|
test performance please |
|
performance test scheduled: 12 job(s) in queue, 1 running. |
|
Performance test finished successfully: Visit http://dotty-bench.epfl.ch/9598/ to see the changes. Benchmarks is based on merging with master (6e6f67b) |
|
That one gives a clear win for dotc. For stdlib we see the same pattern as in the optimize-megaphase commit: go back up to the norm after a very low number for optimize-current. But it seems optimize-current is part of these two as well since it is in master. Which leaves as only explanation for me that we got an outlier for stdlib when we tested optimize-current. |
liufengyun
approved these changes
Aug 20, 2020
| @@ -216,7 +216,10 @@ class Typer extends Namer | |||
| val termName = name.toTermName | |||
|
|
|||
| def adjustExtension(name: Name) = | |||
| if required.is(ExtensionMethod) then name.toExtensionName else name | |||
| if required.is(ExtensionMethod) && termName.endsWith(name.lastPart) | |||
| // pre-check to avoid forming a new string; form extension only if it has a chance of matching `termName` | |||
There was a problem hiding this comment.
Will termName.endsWith(name.lastPart) be always true, given that termName = name.toTermName?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.