Skip to content

Fix Object.range to intended List.range #9595

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 19, 2020
Merged

Fix Object.range to intended List.range #9595

merged 1 commit into from
Aug 19, 2020

Conversation

sullivan-
Copy link

@sullivan- sullivan- commented Aug 19, 2020 •
edited
Loading

I'm pretty certain that the changes here reflect the authors intentions, for two reasons:

  1. Object does not have a range method
  2. The link into the API documentation is pointing to List.range

dottybot
dottybot reviewed Aug 19, 2020
View reviewed changes
Copy link
Member

@dottybot dottybot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, and thank you for opening this PR! 🎉

All contributors have signed the CLA, thank you! ❤️

Have an awesome day! ☀️

smarter
smarter approved these changes Aug 19, 2020
View reviewed changes
Copy link
Member

@smarter smarter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@smarter smarter merged commit 6e6f67b into scala:master Aug 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dottybot dottybot dottybot left review comments

@smarter smarter smarter approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sullivan- @smarter @dottybot