Avoid lazy local contexts #9590
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These cause allocation of a LazyRef. It's better to use inContext, which is an inline function that gives better code.
|
test performance please |
|
performance test scheduled: 3 job(s) in queue, 1 running. |
liufengyun
approved these changes
Aug 19, 2020
| goIdent(tree, start) | ||
| inContext(prepIdent(tree, start)(using outerCtx)) { | ||
| goIdent(tree, start) | ||
| } |
There was a problem hiding this comment.
A digression: the pattern seems to suggest a useful addition to stdlib:
inline def use[T, U](o: T)(inline op: o.type ?=> U): U = op(using o)There was a problem hiding this comment.
If we think in that direction, it seems use can be used to replace given for some use cases:
val ctxInner = prepIdent(tree, start)(using outerCtx)
use ctxInner:
goIdent(tree, start)There was a problem hiding this comment.
yes, but InContext is a bit clearer for reading, I think.
|
performance test failed: Please check http://lamppc37.epfl.ch:8000/pull-9590-08-19-20.50.out for more information |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These cause allocation of a LazyRef. It's better to use inContext,
which is an inline function that gives better code.