Fix #938 #957
Merged
Fix #938 #957
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -488,6 +488,9 @@ class TypeComparer(initctx: Context) extends DotClass with ConstraintHandling { | |||
| case _ => tp2 isRef ObjectClass | |||
| } | |||
| compareJavaArray | |||
| case tp1: ExprType if ctx.phase.id >= ctx.gettersPhase.id => | |||
There was a problem hiding this comment.
Should this be ctx.phase.id > ctx.gettersPhase.id like in https://github.com/dotty-staging/dotty/blob/fix-%23938/src/dotty/tools/dotc/core/TypeComparer.scala#L455 ?
|
LGTM. |
|
/rebuild |
1 similar comment
|
/rebuild |
Need to avoid also symbols in ThisTypes
-Ycheck:era checked after phase resolveSuper. This was due to an overly simplistic containsPhase check.
Getters transform `T` to `=> T`. This means that `=> T <: T` might need to be true after getters. Observed in the wild tree checking t938.scala after getters.
|
Rebased to master |
odersky
added a commit
that referenced
this pull request
Nov 17, 2015
OlivierBlanvillain
pushed a commit
to OlivierBlanvillain/dotty
that referenced
this pull request
Dec 12, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Review by @smarter. And, maybe take it over if there are still things to do.