Skip to content

Fix #937 #955

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 17, 2015
Merged

Fix #937 #955

merged 2 commits into from
Nov 17, 2015

Conversation

odersky
Copy link
Contributor

@odersky odersky commented Nov 15, 2015

This was a tough one. Review by @DarkDimius.

@odersky
Copy link
Contributor Author

odersky commented Nov 15, 2015

Now fixes also #938. Review of last commit by @smarter.

@odersky
Copy link
Contributor Author

odersky commented Nov 16, 2015

Pushed #938 changes to a separate PR.

@odersky
Copy link
Contributor Author

odersky commented Nov 16, 2015

/rebuild

@odersky
Copy link
Contributor Author

odersky commented Nov 16, 2015

@smarter Yes, that was indeed a bug. Good catch.

odersky added a commit that referenced this pull request Nov 17, 2015
@odersky
Merge pull request #955 from dotty-staging/fix-#937
945334c 
Fix #937
@odersky odersky merged commit 945334c into scala:master Nov 17, 2015
OlivierBlanvillain pushed a commit to OlivierBlanvillain/dotty that referenced this pull request Dec 8, 2016
@odersky @OlivierBlanvillain
address "this would catch all throwables" warnings
7eecbfe 
original patch by @odersky in scala#955 -- criterion for the refactor:
"catch Throwable as long as there's no obvious control flow exception going through the catch
and the caught exception is processed further"

rebased & updated with review comments in scala#955 and scala#954
OlivierBlanvillain pushed a commit to OlivierBlanvillain/dotty that referenced this pull request Dec 12, 2016
@odersky @OlivierBlanvillain
address "this would catch all throwables" warnings
7d50958 
original patch by @odersky in scala#955 -- criterion for the refactor:
"catch Throwable as long as there's no obvious control flow exception going through the catch
and the caught exception is processed further"

rebased & updated with review comments in scala#955 and scala#954
@allanrenucci allanrenucci deleted the fix-#937 branch December 14, 2017 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@odersky