Fix Expr.{unlift, unliftOrError} and add missing Unliftables #9513
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liufengyun
approved these changes
Aug 10, 2020
nicolasstucki
force-pushed
the
fix-unliftable
branch
from
2e0598d to
792618a
Compare
* Fix `unlift` to recive the most precise `Unliftable`. Previously we could not add `Unliftable[List[T]]` because the implicit search would fail with an ambigouity between `Unliftable[List[T]]` and `Unliftable[List[T]]`. this came from the `U >: T` bound that was added to workarround the covariant `T`. As extension methods we can simply have the same `T` for the expression type and the unliftable type. This way, we also find the most precise `T`/`Unliftable[T]` available. * Add unliftable for `Nil`/`List` * Add unliftable for `None`/`Some` * Add unliftable for `Map` * Add unliftable for `Set` * Add unliftable for `Left`/`Right` * Add unliftable for `EmptyTuple` * Support `->` in `Tuple2`
nicolasstucki
force-pushed
the
fix-unliftable
branch
from
792618a to
9cba8f5
Compare
nicolasstucki
changed the title
|
@liufengyun I updated the commit message. I also meant |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
unliftto recive the most preciseUnliftable.Previously we could not add
Unliftable[List[T]]because the implicit searchwould fail with an ambigouity between
Unliftable[List[T]]andUnliftable[List[T]].this came from the
U >: Tbound that was added to workarround the covariantT.As extension methods we can simply have the same
Tfor the expression type and theunliftable type. This way, we also find the most precise
T/Unliftable[T]available.Nil/ListNone/SomeMapSetLeft/RightEmptyTuple->inTuple2