Skip to content

fixes #8514, TypeApi#baseType exposed into Tasty #9481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 3, 2020

Conversation

pshirshov
Copy link
Contributor

No description provided.

Copy link
Member

@dottybot dottybot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, and thank you for opening this PR! 🎉

All contributors have signed the CLA, thank you! ❤️

Commit Messages

We want to keep history, but for that to actually be useful we have
some rules on how to format our commit messages (relevant xkcd).

Please stick to these guidelines for commit messages:

  1. Separate subject from body with a blank line
  2. When fixing an issue, start your commit message with Fix #<ISSUE-NBR>:
  3. Limit the subject line to 72 characters
  4. Capitalize the subject line
  5. Do not end the subject line with a period
  6. Use the imperative mood in the subject line ("Add" instead of "Added")
  7. Wrap the body at 80 characters
  8. Use the body to explain what and why vs. how

adapted from https://chris.beams.io/posts/git-commit

Have an awesome day! ☀️

@smarter
Copy link
Member

smarter commented Aug 1, 2020

Please sign the Scala CLA: https://www.lightbend.com/contribute/cla/scala

@pshirshov
Copy link
Contributor Author

@nicolasstucki : I kinda can't understand how do I run these tests in run-macros, so I didn't add a test.

@smarter
Copy link
Member

smarter commented Aug 1, 2020

Macro tests are bootstrapped only, so you can run them using dotty-bootstrapped/testCompilation tests/run-macros/foo (and they're also run by the CI in the test_bootstrapped job)

@pshirshov
Copy link
Contributor Author

@smarter : thanks, that worked. Pushed a basic test. Seems like that should be enough to finish izumi-reflect.

Copy link
Contributor

@nicolasstucki nicolasstucki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise looks good

@nicolasstucki nicolasstucki linked an issue Aug 3, 2020 that may be closed by this pull request
@pshirshov
Copy link
Contributor Author

@nicolasstucki : fixed. Could you accept it now?

@nicolasstucki nicolasstucki merged commit ad4a92b into scala:master Aug 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TASTY: no way to access baseClasses of AppliedType
4 participants