Add RepeatedAnnot to Reflection.defn
#9428
Merged
+10
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abgruszecki
reviewed
Jul 28, 2020
| @@ -1478,8 +1478,14 @@ trait CompilerInterface { | |||
| def Definitions_Array_length: Symbol | |||
| def Definitions_Array_update: Symbol | |||
|
|
|||
| /** A dummy class symbol that is used to indicate repeated parameters | |||
| * compiled by the Scala compiler. | |||
There was a problem hiding this comment.
Can we clarify this or make an issue to clarify this in the future? Does this comment want to convey that this class is only used for Scalac repeated parameters?
There was a problem hiding this comment.
I copied the original comment to the interface. We can revise this documentation later.
There was a problem hiding this comment.
So can we make an issue for it? Or are you keeping track of such things in a different way?
There was a problem hiding this comment.
We will need to do a pass over everything in the API and probably rewrite/improve most of the documentation. Singling a few out does not seem to be worth it.
abgruszecki
approved these changes
Jul 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.