Skip to content

Emit "deprecated" bytecode attribute #9350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 12, 2020

Conversation

TheElectronWill
Copy link
Contributor

@TheElectronWill TheElectronWill commented Jul 12, 2020

Set ACC_DEPRECATED when @deprecated is present. The warning message is also improved.

The memoize phase used to remove all annotations from accessors, it now keeps @deprecated. This way, getters and setters of deprecated fields get the deprecated bytecode attribute, and java can see the deprecation.

@TheElectronWill TheElectronWill merged commit 853b0bf into scala:master Jul 12, 2020
@TheElectronWill TheElectronWill deleted the bytecode-deprecated branch August 10, 2020 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants