Skip to content

Remove QuoteContext reporting implicit conversion #9315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 8, 2020
Merged

Remove QuoteContext reporting implicit conversion #9315

merged 2 commits into from
Jul 8, 2020

Conversation

nicolasstucki
Copy link
Contributor

Now use Reporting.{error, warning, throwError} directly.

@nicolasstucki
Remove QuoteContext reporting implicit conversion
c88399a 
Now use `Reporting.{error, warning, throwError}` directly.
@nicolasstucki nicolasstucki requested a review from liufengyun July 8, 2020 09:40
liufengyun
liufengyun approved these changes Jul 8, 2020
View reviewed changes
Copy link
Contributor

@liufengyun liufengyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nicolasstucki nicolasstucki marked this pull request as ready for review July 8, 2020 12:53
@nicolasstucki nicolasstucki merged commit 9b3fea1 into scala:master Jul 8, 2020
@nicolasstucki nicolasstucki deleted the remove-QuoteContext-reporting-conversion branch July 8, 2020 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liufengyun liufengyun liufengyun approved these changes

Assignees

@liufengyun liufengyun

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nicolasstucki @liufengyun