Add toList method to Tuple #9210
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nerush
reviewed
Jun 19, 2020
anatoliykmetyuk
commented
Jun 19, 2020
nicolasstucki
suggested changes
Jun 20, 2020
Usually you do not want to work with Arrays when doing typeclass derivation, you want Lists. Currently the only way to get a List from a Tuple is `toArray.toList`, which is cumbersome.
anatoliykmetyuk
force-pushed
the
add-toList-to-tuples
branch
from
bc443b2 to
1f6fc97
Compare
nicolasstucki
approved these changes
Jun 24, 2020
Co-authored-by: Nicolas Stucki <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Usually you do not want to work with Arrays
when doing typeclass derivation, you want Lists.
Currently the only way to get a List from a
Tuple is
toArray.toList, which is cumbersome.